mikael-lovqvists-claude-agent/video-setup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix multicast storm: only re-announce on new peer, not every received packet

Browse Source 
The announce thread was being woken (triggering a multicast send) on every
received announcement packet, including ones from already-known peers. With
two or more nodes this created a feedback loop: each incoming packet triggered
an outbound multicast which triggered another incoming packet on the peer, and
so on at full CPU/network speed.

Gate the cond_signal on is_new so we only fast-announce when a genuinely new
peer is seen. The periodic interval-based announcement continues to handle
keepalives and reconnections for existing peers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
mikael-lovqvists-claude-agent
2026-03-30 04:29:50 +00:00
parent 8fa2f33bad
commit b4facf04be
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/modules/discovery/discovery.c
View File

@@ -233,11 +233,13 @@ static void *receive_thread_fn(void *arg) {
pthread_mutex_unlock(&d->peers_mutex); pthread_mutex_unlock(&d->peers_mutex);
/* respond to every announcement — the sender may be a fresh instance if (is_new) {
* that doesn't know about us yet even if we already have it in our table */ /* announce ourselves immediately so the new peer learns about us
pthread_mutex_lock(&d->announce_mutex); * without waiting up to interval_ms */
pthread_cond_signal(&d->announce_cond); pthread_mutex_lock(&d->announce_mutex);
pthread_mutex_unlock(&d->announce_mutex); pthread_cond_signal(&d->announce_cond);
pthread_mutex_unlock(&d->announce_mutex);
}
if (is_new && d->config.on_peer_found) { if (is_new && d->config.on_peer_found) {
d->config.on_peer_found(&peer_copy, d->config.userdata); d->config.on_peer_found(&peer_copy, d->config.userdata);