Add physical dimensions to bin editor for correct aspect ratio
When de-perspectiving a bin photo taken at an angle, inferring the output size from the quadrilateral shape squishes the result. Entering real-world W×H (mm) lets the server use the correct aspect ratio, scaled to the same resolution as the inferred size. - Bin editor dialog: W×H number inputs, pre-filled from saved phys_w/phys_h - PUT /api/bins/:id/corners: accepts optional phys_w/phys_h; when provided, derives bin_w/bin_h from the physical aspect ratio at equivalent area - phys_w/phys_h stored on the bin record for re-use on next edit - future-plans.md: bin types note (reusable dimensions per model) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -2106,6 +2106,8 @@ function open_bin_editor(bin) {
|
||||
|
||||
bin_editor_bin_id = bin.id;
|
||||
document.getElementById('bin-editor-name').value = bin.name;
|
||||
document.getElementById('bin-editor-width').value = bin.phys_w ?? '';
|
||||
document.getElementById('bin-editor-height').value = bin.phys_h ?? '';
|
||||
|
||||
// Show dialog first so the canvas has correct layout dimensions before
|
||||
// load_image reads parentElement.clientWidth to size itself.
|
||||
@@ -2353,6 +2355,8 @@ async function init() {
|
||||
document.getElementById('bin-editor-save').addEventListener('click', async () => {
|
||||
const corners = bin_editor_instance?.get_corners();
|
||||
const name = document.getElementById('bin-editor-name').value.trim();
|
||||
const phys_w = parseFloat(document.getElementById('bin-editor-width').value) || null;
|
||||
const phys_h = parseFloat(document.getElementById('bin-editor-height').value) || null;
|
||||
if (!corners) { alert('Load an image first.'); return; }
|
||||
const id = bin_editor_bin_id;
|
||||
try {
|
||||
@@ -2361,7 +2365,7 @@ async function init() {
|
||||
const r = await api.rename_bin(id, name);
|
||||
updated = r.bin;
|
||||
}
|
||||
const r2 = await api.update_bin_corners(id, corners);
|
||||
const r2 = await api.update_bin_corners(id, corners, phys_w, phys_h);
|
||||
updated = r2.bin;
|
||||
all_bins = all_bins.map(b => b.id === id ? updated : b);
|
||||
document.getElementById('dialog-bin-editor').close();
|
||||
|
||||
Reference in New Issue
Block a user