Make GetPossibleUserByID can handle deleted user (#37430)

Make sure deleted user won't cause 500 error, simplify the caller's code
This commit is contained in:
wxiaoguang
2026-04-27 00:57:53 +08:00
committed by GitHub
parent 2f42c8cf72
commit 068b59aa97
11 changed files with 36 additions and 74 deletions

View File

@@ -104,13 +104,9 @@ func getReleaseInfos(ctx *context.Context, opts *repo_model.FindReleasesOptions)
releaseInfos := make([]*ReleaseInfo, 0, len(releases))
for _, r := range releases {
if r.Publisher, ok = cacheUsers[r.PublisherID]; !ok {
r.Publisher, err = user_model.GetPossibleUserByID(ctx, r.PublisherID)
r.PublisherID, r.Publisher, err = user_model.GetPossibleUserByID(ctx, r.PublisherID)
if err != nil {
if user_model.IsErrUserNotExist(err) {
r.Publisher = user_model.NewGhostUser()
} else {
return nil, err
}
return nil, err
}
cacheUsers[r.PublisherID] = r.Publisher
}